feat(input): add new js and css props #26192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
liamdebeasi
commented
Oct 31, 2022
core/src/components/input/input.tsx
Outdated
| * `'floating'`: The label will appear smaller and above the input when the input is focused or it has a value. Otherwise it will appear on top of the input. | ||
| * `'stacked'`: The label will appear smaller and above the input regardless even when the input is blurred or has no value. | ||
| */ | ||
| @Prop() labelPlacement: 'start' | 'end' | 'floating' | 'stacked' = 'start'; |
There was a problem hiding this comment.
Open to making this labelPosition to keep the API similar to the ion-label position property
There was a problem hiding this comment.
I sort of like labelPlacement to avoid associations with the CSS position property, but I could go either way 😮
Co-authored-by: Amanda Johnston <[email protected]>
sean-perkins
approved these changes
Nov 2, 2022
Co-authored-by: Sean Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A internal ticket
This is one PR of several for the FW-2591 feature
What is the new behavior?
Does this introduce a breaking change?
Other information