feat(input): add color prop support #26237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
reviewed
Nov 8, 2022
There was a problem hiding this comment.
A few screenshot captures have the label cropped, e.g.:
- core/src/components/input/test/color/input.e2e.ts-snapshots/input-outline-color-floating-md-ltr-Mobile-Chrome-linux.png
- core/src/components/input/test/color/input.e2e.ts-snapshots/input-outline-color-floating-md-ltr-Mobile-Firefox-linux.png
- core/src/components/input/test/color/input.e2e.ts-snapshots/input-outline-color-floating-md-ltr-Mobile-Safari-linux.png
- core/src/components/input/test/color/input.e2e.ts-snapshots/input-outline-color-stacked-md-ltr-Mobile-Chrome-linux.png
This is likely because the input bounding box does not contain the translated label for these displays.
|
I'm not seeing the colors when running the test locally on Chrome (screenshot), should I be? |
|
The colors only apply when focusing the input as per the MD spec: https://m2.material.io/components/text-fields |
|
@sean-perkins Do you want me to add top padding to the MD screenshots? I'm not sure how much additional information we would gain by adding it though. |
averyjohnston
approved these changes
Nov 8, 2022
|
I think we are good as-is, as long as the screenshot capture is consistent. We can re-evaluate in the future if it becomes a problem. |
sean-perkins
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Developers using the new input syntax do not have a way of using the Ionic theme to apply a particular theme to
ion-input.What is the new behavior?
colorprop as per the design documentDoes this introduce a breaking change?
Other information