-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(input): label position and overflow is correct #26248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Nov 8, 2022
The bug is not due to the changes in this PR, so I will make open a separate PR. |
averyjohnston
approved these changes
Nov 10, 2022
sean-perkins
approved these changes
Nov 10, 2022
13 tasks
97f9cb1
to
4d6310d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Two issues:
fill
settings onion-input
led to dead space. This was happening because padding was being added to.input-wrapper
. When clicking that padding, you were clicking neither the label nor the input which meant that the input was never focused.fixed
label.What is the new behavior?
.input-wrapper
element is now thelabel
ensuring that there is never any dead space (This is valid usage: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label). This also removes the need to explicitly addhtmlFor
on<label>
.Does this introduce a breaking change?
Other information