Skip to content

fix(input): label position and overflow is correct #26248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 182 commits into from
Nov 11, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 8, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Two issues:

  1. Using certain fill settings on ion-input led to dead space. This was happening because padding was being added to .input-wrapper. When clicking that padding, you were clicking neither the label nor the input which meant that the input was never focused.
  2. Text was not overflowing when using a fixed label.

What is the new behavior?

  • The .input-wrapper element is now the label ensuring that there is never any dead space (This is valid usage: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label). This also removes the need to explicitly add htmlFor on <label>.
  • Added CSS and changed the structure of the label text to ensure that text in the fixed label overflows correctly.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@github-actions github-actions bot added the package: core @ionic/core package label Nov 8, 2022
@liamdebeasi liamdebeasi changed the title 2591 padding fix(input): label position and overflow is correct Nov 8, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 8, 2022 22:25
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 8, 2022 22:25
@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Nov 9, 2022

Moving this back to a draft. Found a bug - will reopen soon

The bug is not due to the changes in this PR, so I will make open a separate PR.

@liamdebeasi liamdebeasi marked this pull request as draft November 9, 2022 15:40
@liamdebeasi liamdebeasi marked this pull request as ready for review November 9, 2022 16:49
Base automatically changed from 2591-tests to FW-2591 November 11, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants