chore: sync script deletes existing tgz packages

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

When testing changes locally, you can have an existing test app that you sync the package contents to. If you have done this across different versions of Ionic, it can install the wrong .tgz file instead of the local changes.

Experienced here: #27040 (review)

Issue URL: N/A

What is the new behavior?

• Sync script deletes all .tgz files local to the directory before locally packing and installing the contents of the parent local packages

Does this introduce a breaking change?

• Yes
• No

Other information

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[liamdebeasi]

Will this work on Windows?

[sean-perkins]

Unfortunately no. I'm not familiar with Windows bash commands, do you know if something like this would work?

if [[ "$(expr substr $(uname -s) 1 6)" == "CYGWIN" ]]; then
  del /s *.tgz
else
  rm -rf *.tgz
fi

Edit: Maybe something like this? (confirmed the linux/unix command works):

#!/bin/bash

set -e

# Delete old packages
if [[ "$(uname)" == "Darwin" || "$(expr substr $(uname -s) 1 5)" == "Linux" ]]; then
    # Linux/Unix
    find . -type f -name "*.tgz" -delete
elif [[ "$(expr substr $(uname -s) 1 6)" == "CYGWIN" ]]; then
    # Windows/Cygwin
    del /s *.tgz
fi

# Pack @ionic/core
npm pack ../../core

# Pack @ionic/vue-router
npm pack ../vue-router

# Install Dependencies
npm install *.tgz --no-save

# Cleanup
if [[ "$(uname)" == "Darwin" || "$(expr substr $(uname -s) 1 5)" == "Linux" ]]; then
    # Linux/Unix
    find . -type f -name "*.tgz" -delete
elif [[ "$(expr substr $(uname -s) 1 6)" == "CYGWIN" ]]; then
    # Windows/Cygwin
    del /s *.tgz
fi

[liamdebeasi]

I've used rimraf before and it's worked pretty well. Maybe we could do that and have rimraf as a project-level dependency?

edit: Actually hmm that may not be a good idea on CI since we'll need to cache node modules for that.

[averyjohnston]

rm -rf works just fine 👀 I just have to do it in a bash terminal (which is already the case with the rest of the script).

[liamdebeasi]

Perfect! In that case, let's just stick with rm.

[liamdebeasi]

Nit: Do we even need the recursive flag here since we're only deleting archives and not directories?

Otherwise this looks good. Thanks for taking care of this!

[sean-perkins]

True, the recursive flag isn't needed here. I'll update that before merging.