Skip to content

test(toast): clean up tests #27435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2023
Merged

test(toast): clean up tests #27435

merged 4 commits into from
May 9, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 9, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

There are several redundant tests I missed during my generator pass.

What is the new behavior?

ec529cf

  • The isOpen tests are testing that you can open/close the modal by triggering the isOpen property. I combined the two tests into 1 test since they are doing the same thing: Checking that the modal opens when isOpen is true and closes when isOpen is false. This also avoids the 500ms timeout of the 2nd test which should speed up execution.

3771d8e

  • Removed the "standalone" screenshot in favor of just checking that the overlay is visible. Rendering of the contents of the overlay are not dependent on ion-app being present.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label May 9, 2023
@liamdebeasi liamdebeasi changed the title Toast tests test(toast): clean up tests May 9, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review May 9, 2023 16:43
@liamdebeasi liamdebeasi requested a review from a team as a code owner May 9, 2023 16:43
@liamdebeasi liamdebeasi enabled auto-merge May 9, 2023 16:43
thetaPC
thetaPC approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit eba4c7f May 9, 2023
@liamdebeasi liamdebeasi deleted the toast-tests branch May 9, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @thetaPC