feat: export TransitionOptions interface and getIonPageElement #28140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoi4
requested review from
liamdebeasi,
thetaPC,
averyjohnston and
sean-perkins
as code owners
github-actions
bot
added
package: core
liamdebeasi
changed the title
liamdebeasi
approved these changes
Sep 8, 2023
3 tasks
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28137
Changes according to this comment
Does this introduce a breaking change?
@liamdebeasi Sorry for replacing the previous PR. I only copied the main branch to my fork so I couldn't rebase properly. I am unfortunately not extremely familiar with Github.