test(item-sliding): re-enable flaky tests #28192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
requested review from
a team and
brandyscarney
and removed request for
a team
...icons/item-sliding.e2e.ts-snapshots/item-sliding-iconsBottom-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...st/icons/item-sliding.e2e.ts-snapshots/item-sliding-iconsEnd-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...t/icons/item-sliding.e2e.ts-snapshots/item-sliding-iconsOnly-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
.../icons/item-sliding.e2e.ts-snapshots/item-sliding-iconsStart-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...st/icons/item-sliding.e2e.ts-snapshots/item-sliding-iconsTop-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandy Carney <[email protected]>
core/src/components/item-sliding/test/icons/item-sliding.e2e.ts
Outdated
Show resolved
Hide resolved
| await page.goto(`/src/components/item-sliding/test/icons`, config); | ||
|
|
||
| const itemIDs = ['iconsOnly', 'iconsStart', 'iconsEnd', 'iconsTop', 'iconsBottom']; | ||
| for (const itemID of itemIDs) { | ||
| await testSlidingItem(page, itemID, itemID, screenshot); | ||
| const itemIDKebab = itemID.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase(); |
There was a problem hiding this comment.
Maybe move this down above the screenshot call and add a comment on why it is here?
Co-authored-by: Brandy Carney <[email protected]>
core/src/components/item-sliding/test/icons/item-sliding.e2e.ts
Outdated
Show resolved
Hide resolved
brandyscarney
approved these changes
Sep 20, 2023
Co-authored-by: Brandy Carney <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
liamdebeasi
pushed a commit
that referenced
this pull request
Sep 22, 2023
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Some of the tests for `item-sliding` were being skipped due to flakiness. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated the tests to use the stable function, `dragElementBy` to handle gestures, removing the gesture flakiness. - Separated the basic test to lessen the gesture complexity else it becomes flaky since it can't handle opening and closing and opening in the same test. - Tests are now checking all modes and all directions. - Updated a utils function with a warning regarding an open issue with RTL. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Brandy Carney <[email protected]>
liamdebeasi
pushed a commit
that referenced
this pull request
Sep 26, 2023
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Some of the tests for `item-sliding` were being skipped due to flakiness. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated the tests to use the stable function, `dragElementBy` to handle gestures, removing the gesture flakiness. - Separated the basic test to lessen the gesture complexity else it becomes flaky since it can't handle opening and closing and opening in the same test. - Tests are now checking all modes and all directions. - Updated a utils function with a warning regarding an open issue with RTL. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Brandy Carney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Some of the tests for
item-slidingwere being skipped due to flakiness.What is the new behavior?
dragElementByto handle gestures, removing the gesture flakiness.Does this introduce a breaking change?
Other information
N/A