feat(theming): add a global --ion-placeholder-opacity variable #28944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
requested review from
a team and
sean-perkins
and removed request for
a team
liamdebeasi
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Developers are unable to globally change the placeholder opacity for inputs, textareas, searchbars, and selects. This becomes particularly problematic when trying to apply a high contrast theme.
What is the new behavior?
--ion-placeholder-opacitywith a fallback of0.6(this fallback is unchanged)--ion-placeholder-opacityto0.8for the high contrast light & dark themesNote
The ticket says to update the standard light and dark themes to define
--ion-placeholder-opacity: 0.6, however, I did not do this because this is not different than the fallback and therefore does not need to be defined.Does this introduce a breaking change?
Other information
Documentation pull request: ionic-team/ionic-docs#3421