refactor(input): remove legacy property and styling #29019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
2 tasks
brandyscarney
requested review from
liamdebeasi,
thetaPC,
sean-perkins and
a team
as code owners
brandyscarney
commented
Feb 12, 2024
| $input-ios-padding-bottom: $item-ios-padding-bottom !default; | ||
|
|
||
| /// @prop - Margin start of the input | ||
| $input-ios-padding-start: 0 !default; |
There was a problem hiding this comment.
These variables were only used by the legacy input
brandyscarney
commented
Feb 12, 2024
Comment on lines
-10
to
-21
| /// @prop - Margin top of the input | ||
| $input-md-padding-top: 10px !default; | ||
|
|
||
| /// @prop - Margin end of the input | ||
| $input-md-padding-end: 0 !default; | ||
|
|
||
| /// @prop - Margin bottom of the input | ||
| $input-md-padding-bottom: 10px !default; | ||
|
|
||
| /// @prop - Margin start of the input | ||
| $input-md-padding-start: ($item-md-padding-start * 0.5) !default; | ||
|
|
There was a problem hiding this comment.
These variables were only used by the legacy input
liamdebeasi
reviewed
Feb 13, 2024
liamdebeasi
approved these changes
Feb 13, 2024
brandyscarney
added a commit
that referenced
this pull request
Feb 13, 2024
brandyscarney
added a commit
that referenced
this pull request
Feb 13, 2024
brandyscarney
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the changes to remove the legacy property for the input as part of #29017. That pull request specifically focuses on updating tests to remove any legacy input usage. The internal ticket suggested separating these changes into individual pull requests. Please refer to the mentioned pull request for a detailed description of the combined changes from both pull requests. This will be merged into that pull request upon approval.