docs(app): add setFocus to the documentation #29916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No it will still be linked when this is merged. |
tanner-reits
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29830
What is the current behavior?
The
setFocusmethod onion-appis marked internal.What is the new behavior?
Document the
setFocusmethod as a way for developers to programmatically focus elements.Does this introduce a breaking change?
Other information
The method isn’t new, it was just marked as internal, which prevented it from being documented. I can mark this as a
featthough if anyone thinks it should be.Related documentation PR: ionic-team/ionic-docs#3842