add a MANIFEST.in file #72
Conversation
| prune docs | ||
| prune tests |
There was a problem hiding this comment.
I want to reduce the docs size by solving #71 and we should probably either move the tests to the package or never ship them, otherwise they'll be their own namespace.
There was a problem hiding this comment.
we should probably either move the tests to the package or never ship them, otherwise they'll be their own namespace.
I don't follow -- I think they should be in the sdist, but not installed as part of the package (so not in a wheel).
I think this should do that:
[tool.setuptools]
packages = ["xarray"]
but if not, then we need to fix that.
There was a problem hiding this comment.
NOTE: moving them into the package is a fine idea, but not until we resolve the data files issue.
There was a problem hiding this comment.
Putting them in the sdist with a __init__py will make it a package named tests, installable via pip* or not.
* NB the packages = [ "xarray_subset_grid" ] ensures it is not installed, it is still a package named "tests" for many other tools that inspects this codebase.
There was a problem hiding this comment.
Only tools that try to auto-detect packages -- and why would anyone use those as is? this pyproject file is specifically for setuptools [*].
packages = [ "xarray_subset_grid" ] ensures it is not installed,
Not really -- it tells setuptools what to put in the wheel, when the wheel is built. pip just installs that wheel (or if you point it at source, it calls setuptools to build the wheel first, and then installs it)
In the end, we might want to put the tests inside the package (but maybe not -- there should be many more! But for now, it's OK as is -- this isn't a 1.0 release :-)
[*] setuptools is getting pretty clunky, maybe it's time to go to hatch ...
| prune .github | ||
| prune *.egg-info | ||
| prune docs | ||
| prune tests |
There was a problem hiding this comment.
I don't think we should prune the tests -- it's nice to have them in the sdist. (among other things, you can run them when building a conda package, for instance)
There was a problem hiding this comment.
scratch that -- the tests need data files that are in the docs/examples dir -- so let's leave them out for now after all.
This all needs a lot of restructuring ...
|
sdist now 250k :-) |
Implements #71 (comment) for now.