xcode version check is broken

[kazzmir]

The version check in check_reqs.js uses string comparison rather than something like semver, which causes newer versions of xcode to be considered out of date.

With xcode 10.1 or 10.2 the following check fails:

ios-deploy/src/scripts/check_reqs.js

Line 31 in 3a1c562

if (os.release() >= '15.0.0' && ver < XCODEBUILD_MIN_VERSION) {

'10.1' < '7.0'

$ node
> let a = '10.1'
undefined
> let b = '7.0'
undefined
> a < b
true

The version check should compare the version properly by comparing the major version first, then the minor version if necessary.

[gabebear]

XCODEBUILD_MIN_VERSION is a number, not a string.

Are you hitting an error here? (I'm not arguing that the logic isn't wrong, just wondering if this is actively causing an issue)

'10.1' > 7.0

$ node
> let a = '10.1'
undefined
> let b = 7.0
undefined
> a < b
false

[kazzmir]

Oops sorry you are right. I was looking at the source of ios-deploy 1.9.2 where XCODEBUILD_MIN_VERSION is defined as a string

var XCODEBUILD_MIN_VERSION = '7.0';

[gabebear]

I think the current bad cases are when XCode has a 3-part major.minor.patch version:

> '10.3.2' > 7.0
false

I think we should just remove this check(XCode 7.0 is very old) #382

[shazron]

Fixed in #382