added support for AppleTV OS #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g root_path (some paths weren't working)
|
Awesome, qbs will enjoy this as well. |
|
Reviewed and tested by deploying to an iOS device. Can't test on tvOS, so I'll leave that for users to test. LGTM. merging |
|
1.9.0 published: https://github.com/phonegap/ios-deploy/releases/tag/1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We use your work internally in my company, and we needed to deploy automatically on tvOS, so I tweaked the code to allow that. (thanks by the way for continuing ios-deploy 🎉 )
Please consider my changes.
Some explaination about the patch :
My fix to this issue has not been to fix find_path() per se, but to make it lower level, and escape the paths before calling find_path.
I submit this change from home, so I can't test it with an AppleTV, and your codebase changed slightly, so maybe the patch isn't ready, but it shouldn't be far from it, as it worked on my workplace.
I would appreciate feedbacks, thanks 😄