Skip to content

Conversation

black-square
Copy link

Fixes #256
In my case the command = '-X true --' which makes args = ['-X true ', ''] and it compleately ignored what we have in '{args}'

… parameters

Fixes ios-control#256
In my case the `command = '-X true --'` which makes `args = ['-X true ', '']` and it compleately ignored what we have in `'{args}'`
Copy link

@advntss advntss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Xcode 7 and iphone4.
passed args with
-a "-myparam value"

@black-square
Copy link
Author

Hi @shazron ,
It's a month passed since I created that request. Do you have any policy I need to follow to have that code merged into the master branch? Looks like @advantiss confirmed that it fixed the problem.

@hackjutsu
Copy link

hackjutsu commented Dec 1, 2016

@black-square

I'm running into the exact same issue and have verified your changes on Xcode 7 and iOS 9.1.

To better understand the PR, would you mind sharing some light on how arguments from --args come into {args}? And how it is different from the args from command?

Thanks

@black-square
Copy link
Author

Hi @hackjutsu ,
Sure thing.

  1. String with arguments is stored in global var char *args
  2. Marker {args} in lldb.py is replaced with the value of this var in run_command method
  3. run_command is called from lldb and command comes from lldb (I believe as a parameter of run command, although I see that all the calls of run are without parameters. See lldb_prep_interactive_cmds, lldb_prep_noninteractive_justlaunch_cmds, lldb_prep_noninteractive_cmds)
  4. command in my case always equal '-X true --' which made args = ['-X true ', ''] and it completely ignored what we have in {args}

After my changes, code always combines what we have in command with what we have in {args}

Feel free to ask any questions or rise any concerns.

@shazron shazron merged commit 5f5a9a1 into ios-control:master Jan 26, 2017
@shazron shazron added this to the 1.9.1 milestone Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants