Fixed incorrect logs order in noninteractive mode #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogs in a wrong order. One line could be inserted into the middle of another one. (The order is very important for us as we parse the logs and retrieve some data automatically) - Fixed a problem when iosdeploy in noninteractive mode (ran with XCode since version 8.0 only) started to add `(lldb) ` prefixes before it printed a game log. It added this prefix even in the middle of the line sometimes - Added handling of additional states
|
Hi @black-square I've started to merge all the outstanding PRs before doing testing, but now this PR has some conflicts. Doesn't seem to be a huge conflict but can you help sort it out? Thanks! |
…LogsOrder # Conflicts: # src/scripts/lldb.py
|
@shazron Conflicts have been resolved (had 2 PRs changing the same file). Let me know if you find any issues during the testing. I can try to help to fix them. |
|
Published 1.9.1 https://github.com/phonegap/ios-deploy/releases/tag/1.9.1 - if any issues arise we can do a 1.9.2 (I did a basic test of deploying a signed app) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem when the noninteractive mode printed application logs in a wrong order. One line could be inserted into the middle of another one. (The order is very important for us as we parse the logs and retrieve some data automatically)
Fixed a problem when iosdeploy in noninteractive mode (ran with XCode since version 8.0 only) started to add
(lldb)prefixes before it printed a game log. It added this prefixes even in the middle of the line sometimesAdded handling of additional states