feat: add ability to inject arbitrary environment variables #354
Conversation
|
Would love to see this merged into master. Thanks @palmerc! |
|
Agreed. I've tried starting ios-deploy in the |
|
If you look at what Xcode passes to the debugserver you'll see the that this environment variables are handled this way. I wish they'd accept this onto master |
|
@shazron this seems like something I should be able to get on master. Any particular reason you can't accept the PR? |
|
No reason, I haven't gotten around to testing the PR. Testing now. |
|
Tested with these, and they work well, I can see the env vars during runtime in my app: I am adding a review note above for two changes that are needed (docs) |
src/ios-deploy/ios-deploy.m
Outdated
| @" -c, --detect only detect if the device is connected\n" | ||
| @" -b, --bundle <bundle.app> the path to the app bundle to be installed\n" | ||
| @" -a, --args <args> command line arguments to pass to the app when launching it\n" | ||
| @" -s, --envs <envs> environment variables to pass to the app when launching it\n" |
There was a problem hiding this comment.
Need to probably mention that key value pairs need to be space separated, e.g.
FOO=BAR BAZ=FAZ
Please also add an example in the Examples section of the README.md
|
@shazron I think that it should match your requested changes now. |
|
Tip for next time - don't squash your changes. It makes it easier for me to review any new changes since I last re-tested. If squashed, I would have to re-test the whole thing again if I doubt its veracity, but in this case through visual inspection from the previous it looks fine. GH has a way to squash it neatly when I merge it in. |
|
Hey! Sorry for bothering, but is there any chance to know when this might get in the release? |
shazron
changed the title
5 participants
Sometimes you need to pass environment variables to the remote debugging session just like Xcode. I added the ability to do this.