fix: fix parsing the short optional arguments #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes parsing of the optional argument to the short options `-l` (for `--list`) and `-w` (for `--download`) to accept the target file/directory on the iOS device. The functionality was already implemented and working with the long version of the options. That is: * `-l /Library` did not work and is fixed now; * `--list=/Library` used to and continues to work; * `--list /Library` did not and does not work (`getopt_long` doesn't support that). The fix is to remove double colons after these short options. A few unused one-letter options were also removed.
shazron
changed the title
|
Just listing the changes here for clarity:
|
|
Resolved conflict: added |
geekonion
pushed a commit
to geekonion/ios-deploy
that referenced
this pull request
Jun 29, 2023
This patch fixes parsing of the optional argument to the short options `-l` (for `--list`) and `-w` (for `--download`) to accept the target file/directory on the iOS device. The functionality was already implemented and working with the long version of the options. That is: * `-l /Library` did not work and is fixed now; * `--list=/Library` used to and continues to work; * `--list /Library` did not and does not work (`getopt_long` doesn't support that). The fix is to remove double colons after these short options. A few unused one-letter options were also removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes parsing of the optional argument to the short options
-l(for--list) and-w(for--download) to accept the targetfile/directory on the iOS device. The functionality was already
implemented and working with the long version of the options. That is:
-l /Librarydid not work and is fixed now;--list=/Libraryused to and continues to work;--list /Librarydid not and does not work (getopt_longdoesn'tsupport that).
The fix is to remove double colons after these short options. A few
unused one-letter options were also removed.