feat: add JSON Output Option #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing --json when running detection will output json dictionaries for each device detected.
|
I just tested this, ios-deploy/src/ios-deploy/ios-deploy.m Line 1826 in 3a1c562 |
|
oops, I'd added that "::j" to a different branch when I was testing... |
shazron
reviewed
May 7, 2019
src/ios-deploy/ios-deploy.m
Outdated
| int ch; | ||
|
|
||
| while ((ch = getopt_long(argc, argv, "VmcdvunNrILeD:R:i:b:a:s:t:g:x:p:1:2:o:l::w::9::B::W", longopts, NULL)) != -1) | ||
| while ((ch = getopt_long(argc, argv, "VmcdvunNrILeD:R:i:b:a:s:t:g:x:p:1:2:o:l::w::9::B::W::j", longopts, NULL)) != -1) |
There was a problem hiding this comment.
I would append the string with j instead of appending ::j. The effect here is you are specifying W::, that -W takes an optional parameter. I know that this opt string stuff is not exactly intuitive... (you could also prepend the string with j, same effect)
Also moves "-W" to same section of string with other no-arg options (Makes it easier to remember that "::" after a parameter means something, not before it).
shazron
approved these changes
May 9, 2019
geekonion
pushed a commit
to geekonion/ios-deploy
that referenced
this pull request
Jun 29, 2023
* Add JSON Output option * passing --json when running detection will output json dictionaries for each device detected. * add -j option to check Also moves "-W" to same section of string with other no-arg options (Makes it easier to remember that "::" after a parameter means something, not before it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125
passing --json when running detection will output json dictionaries for each device detected.