Skip to content

Allocate ref on stack instead of the type itself for AFC service startup #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Allocate ref on stack instead of the type itself for AFC service startup #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ios-deploy/MobileDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ mach_error_t AMDeviceStartSession(struct am_device *device);
*/

mach_error_t AMDeviceStartService(struct am_device *device, CFStringRef
service_name, ServiceConnRef handle, unsigned int *
service_name, ServiceConnRef * handle, unsigned int *
unknown);

mach_error_t AMDeviceStartHouseArrestService(struct am_device *device, CFStringRef identifier, void *unknown, ServiceConnRef handle, unsigned int *what);
Expand All @@ -290,7 +290,7 @@ mach_error_t AMDeviceStopSession(struct am_device *device);
* MDERR_AFC_OUT_OF_MEMORY if malloc() failed
*/

afc_error_t AFCConnectionOpen(service_conn_t handle, unsigned int io_timeout,
afc_error_t AFCConnectionOpen(ServiceConnRef handle, unsigned int io_timeout,
AFCConnectionRef *conn);

/* Pass in a pointer to an afc_device_info structure. It will be filled. */
Expand Down
2 changes: 1 addition & 1 deletion src/ios-deploy/ios-deploy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,7 +1520,7 @@ AFCConnectionRef start_afc_service(AMDeviceRef device) {
check_error(AMDeviceStartSession(device));

AFCConnectionRef conn = NULL;
service_conn_t serviceConn;
ServiceConnRef serviceConn = NULL;

if (AMDeviceStartService(device, AMSVC_AFC, &serviceConn, 0) != MDERR_OK) {
on_error(@"Unable to start file service!");
Expand Down