Skip to content

Conversation

Ukalnins
Copy link

This still needs some testing on older macOS/iOS/Xcode versions, but created the PR to get some feedback.

This PR should allow:

  • Detecting watchOS devices connected trough iPhone
  • Listing installed bundles
  • Uninstalling/Installing on said watchOS device
  • Starting debugger and application on said watchOS device

Looks like starting AFC service on watchOS is not possible, so copying files there and back again is also not possible.

Copy link

@gabebear gabebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, leaving it up to @ivanhernandez13 to figure out what gets merged first. I think it makes sense to get this merged and follow with any needed fixes since it largely seems to work.

@ivanhernandez13
Copy link

Thanks for the PR and sorry for the delay.

This change looks good to me as well, and works well from playing around with it using Xcode 12.4 + iOS 14.5 + watchOS 7.4. @Ukalnins do you want to merge this in now or is there some additional changed you'd like to do?

I have a very minor change I'd like to merge as well but can merge this in first if you'd like.

@Ukalnins
Copy link
Author

This change looks good to me as well, and works well from playing around with it using Xcode 12.4 + iOS 14.5 + watchOS 7.4. @Ukalnins do you want to merge this in now or is there some additional changed you'd like to do?

I have a very minor change I'd like to merge as well but can merge this in first if you'd like.

I would like to test that building on macOS-10.14 still works and iOS-10 also still works. Hadn't had the time unfortunately. I'll try to do it tomorrow and report back if I had any issues.

You are welcome to merge your change and not wait for this.

@Ukalnins Ukalnins force-pushed the add_basic_support_for_watchos branch from d32dd40 to df28c5d Compare February 19, 2021 09:58
@Ukalnins
Copy link
Author

Looks like this PR does not break anything on Mojave nor iOS 10.x or tvOS, so I think this can be merged.

@ivanhernandez13 ivanhernandez13 merged commit 972a328 into ios-control:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants