This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Fix: Adds recently requested txs set to TransactionRequester #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
luca-moser
changed the title
GalRogozinski
approved these changes
Jul 25, 2019
| @@ -1,9 +1,7 @@ | |||
| package com.iota.iri.network; | |||
|
|
|||
| import java.security.SecureRandom; | |||
There was a problem hiding this comment.
Hmm on my IDE I see that it is not being used.
Since you changed imports automatically I would think that it would have been removed automatically.
It is out of context of this PR, so I don't care too much
| @@ -20,6 +18,7 @@ | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(TransactionRequester.class); | |||
| private final Set<Hash> transactionsToRequest = new LinkedHashSet<>(); | |||
| private final Set<Hash> recentlyRequestedTransactions = Collections.synchronizedSet(new HashSet<>()); | |||
There was a problem hiding this comment.
The other option would be
ConcurrentHashMap.newKeySet() which is more performant under heavy contention.
However, I don't think we have too much contention here, so you probably made the more performant choice 👍
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes transactions to be deemed invalid by their timestamp because the bypass via the
transactionRequester.isTransactionRequested()doesn't work with the new request queue logic via #1530Fixes # (issue)
#1541
Type of change
Checklist: