Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Conversation

GalRogozinski
Copy link
Contributor

@GalRogozinski GalRogozinski commented Jul 29, 2019

Description

Publishes confirmed transactions trytes to zmq with the following format

Fixes #1550

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Documentation Fix

How Has This Been Tested?

TBD
Tested manually

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@jakubcech
Copy link
Contributor

@louaykamel does this work for you?

@louaykamel
Copy link

@jakubcech the code looks clean, so I suppose it does work, anyway will test it later today to confirm.

@jakubcech
Copy link
Contributor

Did it work the way you need it to @louaykamel ? Thanks :)

@louaykamel
Copy link

@jakubcech, @GalRogozinski, It compiles, but wasn't able to receive anything from "sn_trytes",
there is still something missing!

@DyrellC
Copy link
Contributor

DyrellC commented Sep 16, 2019

I was able to receive the sn_trytes when testing on my end

@jakubcech
Copy link
Contributor

Can be merged. ✔️ by LK

@louaykamel
Copy link

Thank you guys for your hard work!

@GalRogozinski
Copy link
Contributor Author

@louaykamel
WilI finally merge it to next version
Are the bundles coming indeed in order?

@GalRogozinski
Copy link
Contributor Author

Shouldn't be merged until documentation is ready

Copy link
Contributor

@DyrellC DyrellC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish works on my end, just needs the documentation

Copy link
Contributor

@DyrellC DyrellC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray for documentation

@GalRogozinski GalRogozinski merged commit 2e9512d into iotaledger-archive:dev Jan 13, 2020
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sn_trytes, a custom zmq topic.
4 participants