Skip to content
This repository was archived by the owner on Apr 16, 2021. It is now read-only.

post: release of js-libp2p 0.27 #357

Merged
merged 5 commits into from
Feb 7, 2020
Merged

post: release of js-libp2p 0.27 #357

merged 5 commits into from
Feb 7, 2020

Conversation

jacobheun
Copy link
Collaborator

For the libp2p 0.27 release, libp2p/js-libp2p#487.

Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only reservation is that this is a modest post for such a ground breaking release!

@alanshaw
Copy link
Contributor

Maybe it could do with some intro text to explain the scope of the effort and changes? Also, got any stats or graphs on perf improvements we can see?

@jacobheun
Copy link
Collaborator Author

I'll put an intro together for the changes. Ideally I'd like to reference the async refactor blog post you're working on for the broader picture and I could focus on some of the libp2p specifics.

@alanshaw
Copy link
Contributor

alanshaw commented Feb 1, 2020

I'll put an intro together for the changes. Ideally I'd like to reference the async refactor blog post you're working on for the broader picture and I could focus on some of the libp2p specifics.

It ship! https://blog.ipfs.io/2020-02-01-async-await-refactor/

@alanshaw
Copy link
Contributor

alanshaw commented Feb 7, 2020

Did you want to add some more to this post @jacobheun or shall we merge? Although, probably a good idea to change the date before we do!

@vasco-santos
Copy link
Contributor

If we plan to go as this is let me know, so that I can read this first, as I was waiting for additions before reviewing.

@jacobheun
Copy link
Collaborator Author

Did you want to add some more to this post @jacobheun or shall we merge? Although, probably a good idea to change the date before we do!

Yes, I'll work on finishing this up today and re request reviews and ping when ready.

@jacobheun
Copy link
Collaborator Author

@alanshaw @vasco-santos added an intro, including links to the recent refactor blog posts, and the metrics we gathered around memory usage improvements. This should be ready for review, let me know if you think I missed anything.

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! 👍
LGTM! 🚢

@jacobheun jacobheun requested a review from alanshaw February 7, 2020 16:28
@jacobheun jacobheun merged commit 8d6f5b8 into master Feb 7, 2020
@jacobheun jacobheun deleted the post/libp2p-0.27 branch February 7, 2020 18:18
momack2 pushed a commit that referenced this pull request Feb 14, 2020
* Create 081-js-libp2p-0.27.md

* Apply suggestions from code review

Co-Authored-By: Alex Potsides <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Alan Shaw <[email protected]>

* blog: add intro to js-libp2p refactor and update date

* chore: apply suggestions from code review

Co-Authored-By: Alan Shaw <[email protected]>

Co-authored-by: Alex Potsides <[email protected]>
Co-authored-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants