-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only reservation is that this is a modest post for such a ground breaking release!
Maybe it could do with some intro text to explain the scope of the effort and changes? Also, got any stats or graphs on perf improvements we can see? |
I'll put an intro together for the changes. Ideally I'd like to reference the async refactor blog post you're working on for the broader picture and I could focus on some of the libp2p specifics. |
It ship! https://blog.ipfs.io/2020-02-01-async-await-refactor/ |
Did you want to add some more to this post @jacobheun or shall we merge? Although, probably a good idea to change the date before we do! |
If we plan to go as this is let me know, so that I can read this first, as I was waiting for additions before reviewing. |
Yes, I'll work on finishing this up today and re request reviews and ping when ready. |
Co-Authored-By: Alex Potsides <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
7119b0c
to
7e17b39
Compare
@alanshaw @vasco-santos added an intro, including links to the recent refactor blog posts, and the metrics we gathered around memory usage improvements. This should be ready for review, let me know if you think I missed anything. |
Co-Authored-By: Alan Shaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! 👍
LGTM! 🚢
* Create 081-js-libp2p-0.27.md * Apply suggestions from code review Co-Authored-By: Alex Potsides <[email protected]> * Apply suggestions from code review Co-Authored-By: Alan Shaw <[email protected]> * blog: add intro to js-libp2p refactor and update date * chore: apply suggestions from code review Co-Authored-By: Alan Shaw <[email protected]> Co-authored-by: Alex Potsides <[email protected]> Co-authored-by: Alan Shaw <[email protected]>
For the libp2p 0.27 release, libp2p/js-libp2p#487.