This repository was archived by the owner on Jun 2, 2020. It is now read-only.
feat: integrate browser-addressing content #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces link to external SPEC with dedicated guide which integrates more natively with the rest of docs.ipfs.io and provides more elaborate introduction of each addressing scheme. Closes #256 License: MIT Signed-off-by: Marcin Rataj <[email protected]>
jessicaschilling
suggested changes
Sep 30, 2019
There was a problem hiding this comment.
This is great -- thank you for assembling all of this!
I've made a handful of minor copy edits (mainly adding articles) ... please feel free to incorporate them, or if you don't have the time let me know and I'll make them as direct edits. Just didn't want to go in changing your stuff without your permission. 😊
License: MIT Signed-off-by: Marcin Rataj <[email protected]>
|
@jessicaschilling thanks, I applied your suggestions ✔️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces external link "Addressing in Browser" with a dedicated guide which integrates better with the rest of docs.ipfs.io and provides more elaborate introduction of each addressing scheme.
Needs proofing, aims to close #256 and act as an introduction to more technical SPEC aimed at implementers (https://github.com/ipfs/in-web-browsers/issues/147)
cc https://github.com/ipfs/in-web-browsers/issues/147, @autonome