This repository was archived by the owner on Jun 2, 2020. It is now read-only.
Re-build the theme/layout #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `static-build` folder (where all the generated JS and CSS code winds up) is now `build` (Hugo had some confusing issues with folder that have dashes in the name). Still lots to recreate in the style and layout, but this covers high-level bits and the header. License: MIT Signed-off-by: Rob Brackett <[email protected]>
For now, we are keeping font-awesome, but may want to remove it when we fully redesign, since we have/are building our own icon set for IPFS projects (ipfs-shipyard/ipfs-css).
This moves the footer from stretching across the full screen bottom to simply being at the end of the content -- handling the way the old footer worked requires some JS that doesn't seem especially necessary. We can re-examine this in the full redesign.
This is kinda ugly and contains a lot of copy/pasted CSS code from the previous version. It cleans up the CSS and the HTML classes a *little,* but largely keeps the same layout and look.
This used to dynamically flip between showing only the site title or page title, depending on whether the `<h1>` of the main content was still on screen or scrolled away. We might want to bring that back, but for short-term simplicity's sake, we just keep this static and insert a dash.
|
I still need to redo the small screen menu, but that should mostly be all that’s left at this point. |
|
OK, this should be ready to merge. Again, this is just supposed to be a minimal reproduction of what we previously had with less JS and with readable code. There are a few minor layout/design tweaks (the footer has moved, the menu has some better accessibility features), but it’s not meant to be too special and is likely something we’ll just throw away in a later redesign. Care to review at all, @lgierth, @kyledrake, @olizilla? (I’ll merge after one of you 👍) Once this is merged, this site should be ready to push live! (Still lots to improve on it, but it’s at least usable.) |
|
This looks great :):):) |
ghost
approved these changes
Jul 26, 2018
|
MERGIFYING |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress; DO NOT MERGE!(UPDATE: this is mergeable now)We are removing the old theme (which was broken in a number of ways) and rewriting a very minimal and simple version. A future PR will focus on an actual redesign, but here we're just making it shippable.
MUCH ❤️to @eocarragain for help here!
Fixes #77