This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Fixes timeout ms arg being erroneously passed to pubsub.peers #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
alanshaw
commented
Jan 8, 2018
| ipfs2.pubsub.unsubscribe(topicOther, sub2) | ||
| ipfs3.pubsub.unsubscribe(topicOther, sub3) | ||
| done() | ||
| }, 10000) |
There was a problem hiding this comment.
10000 is being passed to pubsub.peers not to setTimeout (which I believe is what was intended)
daviddias
approved these changes
Jan 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and removes the timeout...it shouldn't be required
Also fixes a typo I noticed in the pubsub spec.