This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/\s.?B$/gm
- hmm that doesn't look right to me.Are the
gm
modifiers needed? Does the test pass? If not, please ensure the test passes locally before requesting a review. If you need any help linking and running only this test then ping me on IRC.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap, sorry, the modifiers are not needed @alanshaw. Furthermore, I'll update the expression, I'll make it more specific.

I wouldn't have asked for a second review if the test was not passing locally. You can see it passing here:
This is the
res
objectMy regex was matching:


and
What do you think about this regex? Does this one seem better? It would match the whole string instead of just the units.
/^[\d]+(\.[\d]+)?\s[KMGTP]?B$/
Considering the


res
object (mentioned above), this new regex will match:and