This repository was archived by the owner on Mar 10, 2020. It is now read-only.
test: dht testing #782
Merged
test: dht testing #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Failing tests are from before (PubSub and Windows) |
alanshaw
approved these changes
Jun 4, 2018
danieldaf
pushed a commit
to danieldaf/js-ipfs-api
that referenced
this pull request
Jul 21, 2018
* test: testing * test: more dht testing * chore: update deps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dht.findprovs endpoint is inconsistent with the other endpoints when reporting errors. It sends a message like:
While others wrap it in a JSON object with more info:
This breaks our parser because it is expecting that the messages are standardized.
I'm testing these with the ipfs-inactive/interface-js-ipfs-core#288