This repository was archived by the owner on Apr 29, 2020. It is now read-only.
chore(dependencies) update to latest version of content #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One that validates that a content-type header is present
hugomrdias
pushed a commit
that referenced
this pull request
Jul 4, 2018
This also contains the changes from #1
ghost
assigned 
|
@wraithgar changes already in with #6 I'll setup jenkins for this repo and with that define a min node version. closing without merging because of the package-lock.json which is already ignored in master. Ty |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some testing on the js-ipfs http interface I found that it was passing the
content-typeheader directly into content, which wasn't then checking that that header was present in the first place. This resulted in a traceback and a 500 error.I submitted a patch to content to check for this parameter, and this PR brings this library up to that version.
This does cross a major version boundary however, and the difference between content 3 and 4 is that version 4 moved to node 8 support only. Not sure what the node version requirements on this repo are.