This repository was archived by the owner on Apr 29, 2020. It is now read-only.
feat: allow overriding of internal functions #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interesting bits of this module are the various ways of building DAGs for files and folders (flat, sharded, etc). Sometimes we want to utilise bits of this logic to build DAGs without having to reimplement big chunks of this module. This PR allows the user to pass in functions to replace key parts of this import pipeline. Enables: * ipfs-inactive/js-ipfs-mfs#73 * #46
This was referenced Jan 13, 2020
|
@mikeal I think this should allow you to accomplish #45 and #46 - see the tests here largely 'inspired' by the tests added to those PRs. It does it in a way that lets me do ipfs-inactive/js-ipfs-mfs#73 using the same mechanism. |
|
I pulled down the branch and wrote what I need against it and can say for certain that it works and does what I need. +1 |
alanshaw
approved these changes
Jan 15, 2020
| @@ -145,8 +146,28 @@ The input's file paths and directory structure will be preserved in the [`dag-pb | |||
| - `blockWriteConcurrency` (positive integer, defaults to 10) How many blocks to hash and write to the block store concurrently. For small numbers of large files this should be high (e.g. 50). | |||
| - `fileImportConcurrency` (number, defaults to 50) How many files to import concurrently. For large numbers of small files this should be high (e.g. 50). | |||
|
|
|||
| ## Overriding internals | |||
|
|
|||
| Several aspects of the importer are overridable by specifying functions as part of the options object with these keys: | |||
There was a problem hiding this comment.
It would be useful to know the role of each of these in addition to their signature and return type. It’s great that they can be overridden but I don’t see why/how a user can use it without knowing what part these functions play in the import process.
|
Released as |
This was referenced Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interesting bits of this module are the various ways of building DAGs for files and folders (flat, sharded, etc).
Sometimes we want to utilise bits of this logic to build DAGs without having to reimplement big chunks of this module.
This PR allows the user to pass in functions to replace key parts of this import pipeline.
Enables: