Implemented 'ipfs files' API #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi I found creating the class based arguments necessary to address all the permutations for required/optional arguments. The used of overloaded functions seems limiting to address this. |
|
Thanks for the PR. The files api was added in a recent PR and permutations for arguments have mostly been addressed in PR: #206 |
|
you’re welcome!
…On Tue, Jan 24, 2023 at 6:44 AM kevodwyer ***@***.***> wrote:
Thanks for the PR. The files api was added in a recent PR and permutations
for arguments have mostly been addressed in PR: #206
<#206>
—
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEF4IZLOCVPYFQCJZAW4N6LWT7MEDANCNFSM6AAAAAAQMTINFY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work builds off of a previous, though incomplete, PR by JianYongKang/java/ipfs-http-client. It addresses all potential command argument permutations by adding a class based argument which uses a builder style pattern for caller to specify desired arguments to the files API calls. Open to suggestions as to how this or perhaps an alternative implementation can evolve to address the complete API. Also implemented the 'files write' api by leveraging existing Multipart.java with minor addition for consistency in specifying read/connection timeouts that was present in IPFS.java.
Tests added to APITest.java via APITest.testFiles() method.