Allow cancellation for network requests #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelvoss
force-pushed
the
cancellable-requests
branch
from
b18dd6a to
71cab67
Compare
marcelvoss
force-pushed
the
cancellable-requests
branch
from
71cab67 to
d72284b
Compare
alexsmith84
suggested changes
Jul 4, 2020
|
|
||
| class CancellableRequestTests: XCTestCase { | ||
|
|
||
| func testCancellableRequest() { |
There was a problem hiding this comment.
This tests the mock but is missing the test for the CancellableDataTask struct.
|
|
||
| func testCancellableRequest() { | ||
| let task = MockURLSessionDataTask() | ||
|
|
There was a problem hiding this comment.
Suggested change
| let cancellableTask = CancellableDataTask(request: task) |
| cancellationExpectation.fulfill() | ||
| } | ||
|
|
||
| task.cancel() |
There was a problem hiding this comment.
Suggested change
| task.cancel() | |
| cancellableTask.cancel() |
alexsmith84
approved these changes
Jul 4, 2020
|
is there an 18 month waiting period for approved changes? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
while browsing through the code base I noticed that at the moment it is impossible to cancel any network requests, although this is something that needs to happen rather often in mobile applications (reachability etc).
I thought about a way to sensibly return the requests without exposing implementation details of the networking layer to any module integrators and went with protocols (yay). This way we can don't need to expose the URLSessionDataTask objects themselves but only expose a protocol that has a single
cancel()function. Tl;Dr: even though the networking code might change at some point, the integrator will still only receive any object conforming to the protocol. I think this is the cleanest solution for this.Most importantly: the return value is discardable (thanks to
@discardableResult) and will not change anything for current integrators.