This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Fix cyclic gx dep #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2018 21:04
|
I can't reproduce the issue. This appears to work just fine. |
|
Mh yeah weird... I was doing Who knows what I did wrong there -- the other day I started using myrepos again and thus properly refreshed and checkout'd all our repos, so maybe something was just out of date. Closing this and will rebase #10 back on master. |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dep cycle came into effect when trying to
gx-go linkthis gx package. Theserializego package wasn't able to get theipfs/go-ipfs-configimport rewritten. This resulted in rewritten-vs-unrewritten type errors.Gx is a lot easier on you if imports, within one gx package, only point lower in the filesystem, never to parent directories or sibling directories.