feat: default minimum and maximum connections

[hacdias]

Set the range to 200-300. The default was 300-600. Ref: #665

License: MIT
Signed-off-by: Henrique Dias [email protected]

[olizilla]

I'm in favour of this change, but for posterity, we should replace it with a desktop profile in IPFS core when it is available ipfs/kubo#4989

Some initial thoughts for a desktop user:

• probably want dhtclient. Most desktop users are behind NAT, and it's better to default assume NAT's arent traversable
• connection manager limits probably want to be low (50-150 ish) but with a higher grace period, perhaps several minutes.
• mdns and NAT port mapping should be enabled
• relay addresses should be advertised

[lidel]

What if user changes HighWater via Settings in Web UI?
IIUC this will override configuration on every start, confusing users trying to change this value.

Would it be possible to run it only once (eg. after ipfs init)?
That way it will feel more like profile proposed in ipfs/kubo#4989

[olizilla]

@lidel good news, the logic only runs on init!

https://github.com/ipfs-shipyard/ipfs-desktop/blob/62317e02bb6f534c5806c0c6c204bfacf09999e7/src/utils/daemon.js#L39-L41

[lidel]

Ah, my bad. Looks good then!
We coukd ensure mDNS is enabled too (in case default in go-ipfs chcnges), but that can be separate PR.

[olizilla]

From @whyrusleeping notes it sounds like we should set the ConnMgr values to

"LowWater": 50,
"HighWater": 200,
"GracePeriod": "300s"

Otherwise

• Discovery.MDNS.enabled is true` by default
• Swarm.DisableNatPortMap is false by default

but we could explicitly set them here. I'm not sure what we'd need to change to ensure

relay addresses should be advertised

[hacdias]

Merging this now with the defaults decided here. Let's hope a desktop profile is created soon so we can just use it! 😄