Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

fix: sharding and query for windows interop #6

Merged
merged 6 commits into from
Nov 4, 2017
Merged

fix: sharding and query for windows interop #6

merged 6 commits into from
Nov 4, 2017

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Nov 3, 2017
@ghost ghost added the status/in-progress In progress label Nov 3, 2017
@daviddias daviddias mentioned this pull request Nov 3, 2017
Closed
daviddias
daviddias commented Nov 3, 2017
View reviewed changes
Copy link
Member Author

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/sharding.spec.js
@@ -84,8 +84,7 @@ describe('ShardingStore', () => {
})
})

// TODO: fix query prefix and orders
describe.skip('interface-datastore', () => {
describe('interface-datastore', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAD!

richardschneider
richardschneider reviewed Nov 3, 2017
View reviewed changes
Copy link
Contributor

@richardschneider richardschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on CI work

@daviddias
Copy link
Member Author

@richardschneider seems that it just needs an update on linting :)

dryajov
dryajov approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dryajov
Copy link
Member

dryajov commented Nov 3, 2017

travis is complaining about deprecated new Buffer() form, should be changed to Buffer.from() to make it happy.

@codecov
Copy link

codecov bot commented Nov 3, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2f42acc). Click here to learn what that means.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   90.81%           
=========================================
  Files             ?        8           
  Lines             ?      283           
  Branches          ?        0           
=========================================
  Hits              ?      257           
  Misses            ?       26           
  Partials          ?        0
Impacted Files Coverage Δ
src/sharding.js 81.15% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f42acc...6f56c2c. Read the comment docs.

@richardschneider
Copy link
Contributor

@diasdavid its ready for a release!

@richardschneider richardschneider mentioned this pull request Nov 3, 2017
Merged
@daviddias daviddias merged commit 845316d into master Nov 4, 2017
@daviddias daviddias deleted the windows-interop branch November 4, 2017 09:12
@ghost ghost removed the status/in-progress In progress label Nov 4, 2017
@richardschneider richardschneider mentioned this pull request Nov 4, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richardschneider richardschneider richardschneider left review comments

@dryajov dryajov dryajov approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees

@richardschneider richardschneider

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddias @dryajov @richardschneider