Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

Dependencies #6

Closed
richardschneider opened this issue Nov 3, 2017 · 2 comments
Closed

Dependencies #6

richardschneider opened this issue Nov 3, 2017 · 2 comments
Labels
kind/support A question or request for support

Comments

@richardschneider
Copy link
Contributor

richardschneider commented Nov 3, 2017 •
edited
Loading

Has anyone looked at the dependencies?

Why is datastore-core, level-js, leveldown and levelup being referenced? They are not used by the source only by the tests. So at a minimum, they should be moved to devDependencies. But this also begs the question "Why are we testing them, if the source code doesn't reference them?"

Should these tests be moved to js-ipfs-repo?
@daviddias
Copy link
Member

@dignifiedquire wanna share what were you thinking at the time? Probably leftovers?

@daviddias daviddias added the kind/support A question or request for support label Nov 3, 2017
@richardschneider richardschneider mentioned this issue Nov 3, 2017
Merged
@dignifiedquire
Copy link
Member

You should be able to remove them safely. I probably forgot to clean those out when I split the datastore repos into individual parts.

richardschneider added a commit that referenced this issue Nov 3, 2017
@richardschneider
chore(package): dev dependencies closes #6
54364cd
daviddias added a commit that referenced this issue Nov 4, 2017
@daviddias
fix: Windows support (#7)
e7c8f25 
* fix: Windows support

* chore: update CI and deps

* another circle

* chore(package): dev dependencies closes #6

* chore: standard coding style

* chore: fix lint errors

* Revert "chore: fix lint errors"

This reverts commit 71a9536.

* chore: more lint issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/support A question or request for support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richardschneider @dignifiedquire @daviddias