feat: use ipfs provider #199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vasco-santos
force-pushed
the
feat/use-ipfs-provider
branch
2 times, most recently
from
5e0c5ff to
21a9ccc
Compare
BREAKING CHANGE: ipfs provider was added in constructor.
vasco-santos
force-pushed
the
feat/use-ipfs-provider
branch
from
21a9ccc to
2166851
Compare
achingbrain
force-pushed
the
main
branch
2 times, most recently
from
669e6fd to
9f8258d
Compare
|
I think since js-ipfs is deprecated we can close this, but we may want to remove the ipfs provider stuff if it hasn't been already. cc @achingbrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ipfs provider was added in constructor.
In the context of
js-ipfsreannouncing blocks to the network ipfs/js-ipfs#2160, this PR aims to extract the provide logic frombitswap, allowingjs-ipfsto be able to control how and when the provide/reprovide happensThis is part of the work for ipfs/js-ipfs#2184, and that PR should be reviewed before merging this.