Upgrade to new block and datastore interface #58
Conversation
There was a problem hiding this comment.
- rm yarn.lock
I see that this is introducing more than an update to how it uses its deps, it is also introducing a whole new API that removes pull-streams from the equation. I feel it is kind of simpler this way, but at the same time, I need to ask know why the change, we can't go back and forth with our APIs, or is there a good reasoning to drop pull-streams at this level, or simply leave it there.
|
|
||
| // setup a repo | ||
| var repo = new IPFSRepo('example', { stores: Store }) | ||
| const repo = new IPFSRepo('example') |
README.md
Outdated
| console.log(block.data.toString() === b.data.toString()) | ||
| const data = new Buffer('hello world') | ||
| multihashing(data, 'sha2-256', (err, hash) => { | ||
| if (err) throw err |
README.md
Outdated
| bs.get(cid, function (err, b) { | ||
| console.log(block.data.toString() === b.data.toString()) | ||
| const data = new Buffer('hello world') | ||
| multihashing(data, 'sha2-256', (err, hash) => { |
README.md
Outdated
| multihashing(data, 'sha2-256', (err, hash) => { | ||
| if (err) throw err | ||
|
|
||
| const block = new Block(data, new CID(hash)) |
README.md
Outdated
| // add the block, then retrieve it | ||
| bs.put(block, (err) => { | ||
| if (err) throw err | ||
| bs.get(block.cid, (err, b) => { |
There was a problem hiding this comment.
and use the cid from the var, just to make it obvious that you don't need to get the cid from the block.
README.md
Outdated
| bs.put(block, (err) => { | ||
| if (err) throw err | ||
| bs.get(block.cid, (err, b) => { | ||
| if (err) throw err |
| * | ||
| * @param {Bitswap} bitswap | ||
| * @returns {void} | ||
| */ | ||
| goOnline (bitswap) { | ||
| this._bitswap = bitswap | ||
| } |
There was a problem hiding this comment.
This method name is a bit misleading. By passing bitswap, we are not necessarily going online (i.e bitswap is offline).
What about addExchange, so that in the future, we even just have to add multiple exchanges and it all works.
There was a problem hiding this comment.
break all the apis
| * Is the blockservice online, i.e. is bitswap present. | ||
| * | ||
| * @returns {bool} | ||
| */ | ||
| isOnline () { | ||
| return this._bitswap != null | ||
| } |
There was a problem hiding this comment.
if above is applied, then this would be: hasExchange
There was a problem hiding this comment.
@dignifiedquire did you get this comment?
| * @param {function(Error)} callback | ||
| * @returns {void} | ||
| */ | ||
| putMany (blocks, callback) { |
There was a problem hiding this comment.
wait, why not pullStream based anymore?
| expect(err).to.not.exist | ||
| const cid = new CID(key) | ||
| const data = new Buffer('A random data block') | ||
| multihashing(data, 'sha2-256', (err, hash) => { |
There was a problem hiding this comment.
For the sake of our users, it is better to call the thing that comes out of multihashing a multihash because that is what it is.
So pull-streams are cool, if you need stream. These apis were a propagation of the underlying blob-store interfaces and eventually I realised that they weren't helping anyone. This is why datastore only has pull-streams for the query interface and regular callback based apis for everything else. |
daviddias
force-pushed
the
next
branch
2 times, most recently
from
099080c to
7eff97f
Compare
Ref ipfs/js-ipfs#787