Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

bug: changelog generator isn't updating package changelogs #4137

Closed
SgtPooki opened this issue Jun 15, 2022 · 2 comments · Fixed by #4144
Closed

bug: changelog generator isn't updating package changelogs #4137

SgtPooki opened this issue Jun 15, 2022 · 2 comments · Fixed by #4144
Labels
need/triage Needs initial labeling and prioritization

Comments

@SgtPooki
Copy link
Member

  • Version:
    All and new versions are impacted by this

  • Platform:
    N/A

  • Subsystem:
    ipfs-http-client

Severity:

Low - An optional functionality does not work.

Description:

changelog for ipfs-http-client is out of date. Probably similar for other packages in the repo: https://github.com/ipfs/js-ipfs

https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-http-client/CHANGELOG.md shows 55.0.0 as the latest, but https://www.npmjs.com/package/ipfs-http-client shows 57.0.1

Steps to reproduce the error:

Just visit the links

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Jun 15, 2022
@SgtPooki
Copy link
Member Author

from @achingbrain in slack:

It's caused by the difference between our old and new changelog generators. A PR that updates the Changelog to be consistent would be 😘👌

@achingbrain
Copy link
Member

isn't updating package changelogs

Not strictly true, semantic-release just puts the latest in an h2 under the top level h1, the previous one used h1 for the latest. Just needs a one-time fixup to convert the h1s to h2s and put them in the correct order.

achingbrain added a commit that referenced this issue Jun 23, 2022
Make changelogs consistent.

Fixes: #4137
achingbrain added a commit that referenced this issue Jun 23, 2022
Make changelogs consistent.  Hopefully my regex-fu hasn't made a mess of this.

Fixes: #4137
SgtPooki referenced this issue in ipfs/js-kubo-rpc-client Aug 18, 2022
Make changelogs consistent.  Hopefully my regex-fu hasn't made a mess of this.

Fixes: #4137
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants