Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

test: another 'add recursive' test #742

Closed
wants to merge 1 commit into from
Closed

Conversation

daviddias
Copy link
Member

Found today that jsipfs files add -r <folder> doesn't always succeed, taking as example folders within js-ipfs repo:

  • ✔︎ jsipfs files add -r src/init-files/init-docs
  • ✔︎ jsipfs files add -r src/init-files
  • ✔︎ jsipfs files add -r src
  • 𝙓 jsipfs files add -r test
» jsipfs files add -r test

assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: need one root
    at reduceToParents (/Users/ground-control/code/js-ipfs/node_modules/ipfs-unixfs-engine/src/builder/balanced/balanced-reducer.js:20:12)                                                                      at reduced (/Users/ground-control/code/js-ipfs/node_modules/ipfs-unixfs-engine/src/builder/balanced/balanced-reducer.js:44:9)
    at /Users/ground-control/code/js-ipfs/node_modules/pull-stream/sinks/reduce.js:10:5
    at /Users/ground-control/code/js-ipfs/node_modules/pull-stream/sinks/drain.js:20:24
    at /Users/ground-control/code/js-ipfs/node_modules/pull-stream/throughs/async-map.js:24:19
    at pull (/Users/ground-control/code/js-ipfs/node_modules/pull-through/index.js:46:22)
    at next (/Users/ground-control/code/js-ipfs/node_modules/pull-through/node_modules/looper/index.js:7:11)
    at /Users/ground-control/code/js-ipfs/node_modules/pull-through/node_modules/looper/index.js:9:18
    at /Users/ground-control/code/js-ipfs/node_modules/pull-through/index.js:62:13
    at pull (/Users/ground-control/code/js-ipfs/node_modules/pull-through/index.js:46:22)

@pgte could you check this?

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) status/in-progress In progress labels Jan 30, 2017
@daviddias daviddias changed the title test: another add recursive test test: another 'add recursive' test Jan 30, 2017
@pgte
Copy link
Contributor

pgte commented Jan 30, 2017

Should be fixed by ipfs-inactive/js-ipfs-unixfs-engine#131

@daviddias
Copy link
Member Author

we need to stop using language like 'should fix' in PR, github is closing PR across repos instead of just closing issues :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants