This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Fixed error message outputs/handling for help commands in CLI #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting jsipfs without any commands crashes it and gives a slightly unclear error message from yargs. I changed this to have yargs display the original help message on starting jsipfs with no commands. Also there is a fix for the --help command messages not being displayed at all.
|
@rodkeys thank you! Great catch, mind updating the tests to reflect this? |
nunofmn
reviewed
Mar 27, 2017
| console.error(yargs.help()) | ||
| process.exit(1) | ||
| }) | ||
|
|
There was a problem hiding this comment.
The Travis tests are failing, because the linting is failing with this added empty line :)
There was a problem hiding this comment.
Thank you for catching this, I will update my code
src/cli/bin.js
Outdated
| .demandCommand(1) | ||
| .fail((msg, err, yargs) => { | ||
| if (err) throw err // preserve stack | ||
| console.error(yargs.help()) |
There was a problem hiding this comment.
Here maybe you could use the showHelp() function instead.
Added Travis fix and yargs.showHelp()
daviddias
approved these changes
Mar 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting jsipfs without any commands crashes it and gives a slightly unclear error message from yargs.
I changed this to have yargs display the original help message on starting jsipfs with no commands.
Also there is a fix for the --help command messages not being displayed at all.