Skip to content

fix: Daemon spawning throws error with the new multiaddr version #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2018
Merged

fix: Daemon spawning throws error with the new multiaddr version #238

merged 1 commit into from
May 6, 2018

Conversation

vasco-santos
Copy link
Member

Closes #237

@vasco-santos vasco-santos requested a review from daviddias May 4, 2018 12:05
@ghost ghost assigned vasco-santos May 4, 2018
@ghost ghost added the status/in-progress In progress label May 4, 2018
@vasco-santos
Copy link
Member Author

The CI is currently breaking, as it needs the last updates on js-ipfs.

@vasco-santos vasco-santos mentioned this pull request May 4, 2018
Closed
dryajov
dryajov approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddias daviddias merged commit a0d2e37 into master May 6, 2018
@daviddias daviddias deleted the fix_daemon-spawning-throws-error-with-the-new-multiaddr-version branch May 6, 2018 13:32
@ghost ghost removed the status/in-progress In progress label May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dryajov dryajov dryajov approved these changes

@daviddias daviddias Awaiting requested review from daviddias

Assignees

@vasco-santos vasco-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasco-santos @dryajov @daviddias