Skip to content

Don't fail on unknown codec / protocol #103

Open
@lidel

Description

@lidel

Various commands return CID or Multiaddr instances.

For example, fetching ipfs.swarm.peers will return peers and their protocols.

The problem is that over time new codecs and protocols identified by new codes from this table appear, and software that uses older version of this library should not crash like it currently does.

Some examples: ipfs/ipfs-webui#2033, ipfs/ipfs-desktop#2363 (comment).

Solution

TBD, may require upstream changes to https://github.com/multiformats/js-multiaddr and https://github.com/multiformats/js-multiformats/, or maybe just ignoring (skipping) unsupported entries is enough?

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium: Good to have, but can wait until someone steps upkind/bugA bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritization

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions