Skip to content

Conversation

remicousin
Copy link
Contributor

This is a first installment of a Water Balance Monitoring Maproom. At present it is only driven by rainfall and Kc (the rest is constant) and it shows only soil moisture and drainage.

I started off the onset maproom. There is not much new to it except the slider to control time. I wanted the colorbar to update to maximum drainage for that option but it's taking too much time to compute so I guess we'll have to resort to fix values per variables for now.

That makes me think that I didn't write text to describe the slider control. Will do that after creating the PR.

Then I will publish this on devi for Jim to demonstrate next week in Senegal. I guess whatever we can improve by then, great, but I don't know when he will demonstrate and Thanksgiving is coming up: so no sweat if it stays as is.

Aaron: so no immediate rush need to review, but Audrey and I will need to keep going next week. There might be "organizational" problems like I symbolically linked to ../onset/calc.py and I have a widgets versions here that I changed. But I don't know if these deserve more emergency.

Audrey: Next week I will really have to go back to the water balance code so I really need you to pick this up and keep going with the Maprooms (now Monitoring, then Historical). I can make a to-do list if this helps: in the Issues section here, or by email, or in a Trello Board, you tell me.

@remicousin remicousin self-assigned this Nov 22, 2022
@remicousin remicousin mentioned this pull request Dec 1, 2022
@remicousin
Copy link
Contributor Author

Alright. I moved away from slider because:
i) the stuff I can do with it are not loading smoothly
ii) the time series itself may act as a slider (clicking on it to update map for that time step) and that's much more useful
iii) can then propose a drop down as alternative date to select date, which is nice because it's also type in.

And that makes me think that I need to update the text about time selection

Copy link
Collaborator

@aaron-kaplan aaron-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you have a working version of this for Senegal because you've demoed it, but I don't see how the version that's in this PR could work. The flex_fcst config is missing from config-sng.yaml, and there are inputs that are used in callbacks but never defined anywhere. Have you forgotten to push some commits?

@aaron-kaplan
Copy link
Collaborator

Make the input boxes narrower so we can fit more than one of them per line?

image

Copy link
Collaborator

@aaron-kaplan aaron-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@remicousin
Copy link
Contributor Author

Make the input boxes narrower so we can fit more than one of them per line?

image

They are much smaller on my laptop. I am not entirely sure how that is controled at present. Can we make this an issue at least until widget/component/controls are one?

Screen Shot 2022-12-16 at 3 05 03 PM

@aaron-kaplan
Copy link
Collaborator

They are much smaller on my laptop. I am not entirely sure how that is controled at present. Can we make this an issue at least until widget/component/controls are one?

Yes.

@remicousin
Copy link
Contributor Author

Just rebased and adjusted to the new controls.py common file.

@remicousin remicousin merged commit fd9ad2c into master Jan 18, 2023
@remicousin remicousin deleted the remic/watbalmonit branch January 18, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants