-
Notifications
You must be signed in to change notification settings - Fork 6
Remic/watbalmonit #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remic/watbalmonit #236
Conversation
Alright. I moved away from slider because: And that makes me think that I need to update the text about time selection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you have a working version of this for Senegal because you've demoed it, but I don't see how the version that's in this PR could work. The flex_fcst config is missing from config-sng.yaml, and there are inputs that are used in callbacks but never defined anywhere. Have you forgotten to push some commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Yes. |
beec256
to
866a6b2
Compare
Just rebased and adjusted to the new controls.py common file. |
…how to have another color
866a6b2
to
3bbd02f
Compare
This is a first installment of a Water Balance Monitoring Maproom. At present it is only driven by rainfall and Kc (the rest is constant) and it shows only soil moisture and drainage.
I started off the onset maproom. There is not much new to it except the slider to control time. I wanted the colorbar to update to maximum drainage for that option but it's taking too much time to compute so I guess we'll have to resort to fix values per variables for now.
That makes me think that I didn't write text to describe the slider control. Will do that after creating the PR.
Then I will publish this on devi for Jim to demonstrate next week in Senegal. I guess whatever we can improve by then, great, but I don't know when he will demonstrate and Thanksgiving is coming up: so no sweat if it stays as is.
Aaron: so no immediate rush need to review, but Audrey and I will need to keep going next week. There might be "organizational" problems like I symbolically linked to ../onset/calc.py and I have a widgets versions here that I changed. But I don't know if these deserve more emergency.
Audrey: Next week I will really have to go back to the water balance code so I really need you to pick this up and keep going with the Maprooms (now Monitoring, then Historical). I can make a to-do list if this helps: in the Issues section here, or by email, or in a Trello Board, you tell me.