CI #328
Merged
CI #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
|
@kgraaf I've rebased after merging the PRs that fixed the tests, and the tests passed in CI. Please review. |
|
I know very little about this sort of thing, but, this looks like a cogent initial set of tests to me, and using CI even a little is definitely a good move |
kgraaf
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs (some of) the fbfmaproom tests in CI.
Ready to review, but not to merge until after the other PRs that fix the broken tests.This version runs the tests on the CI VM, uncontainerized. I want to switch to running everything with
docker runbecause that will let us share a build/test workflow between local and GitHub, and reduce the lockin to GitHub, but it's going to take some work to get that to be fast so I'm going with this version for now.