Add GetOptions to client GET method
#171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the client interface has changed with kube 1.26 the `GetOptions` has
now to be passed in the GET method.
Otherwise you might end up with the following error:
```
cannot use s (variable of type *memorystore.Store) as client.Client value in argument to utils.GetSecretSelector: *memorystore.Store does not implement client.Client (wrong type for method Get)
have Get(_ context.Context, objectKey types.NamespacedName, obj client.Object) error
want Get(ctx context.Context, key types.NamespacedName, obj client.Object, opts ...client.GetOption) error (typecheck)
```
afritzler
force-pushed
the
enh/client-get-options
branch
from
9b42b19 to
647d62e
Compare
adracus
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As the client interface has changed with kube 1.26 the
GetOptionshas now to be passed in the GET method.Otherwise you might end up with the following error: