added switches package #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrigoriyMikhalkin
force-pushed
the
20-reusable-switches
branch
from
d742054 to
b9d9ead
Compare
GrigoriyMikhalkin
force-pushed
the
20-reusable-switches
branch
from
b9d9ead to
829ba10
Compare
|
cc @adracus I also tested it on |
adracus
suggested changes
Nov 23, 2021
cmdutils/switches/switches_test.go
Outdated
|
|
||
| By("updating settings with empty value") | ||
| Expect(s.Set("")).NotTo(HaveOccurred()) | ||
| Expect(s.settings).To(Equal(defaults)) |
There was a problem hiding this comment.
We shouldn't access private values in tests.
|
@adracus Ready for re-review. |
adracus
reviewed
Nov 30, 2021
adracus
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/onmetal/controller-utils/issues/20