Skip to content

Clarify ES.48 enforcement rule for void cast of [[nodiscard]] #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Clarify ES.48 enforcement rule for void cast of [[nodiscard]] #1588

merged 1 commit into from
Mar 26, 2020

Conversation

shaneasd
Copy link
Contributor

@shaneasd shaneasd commented Mar 16, 2020 •
edited
Loading

As written, that rule would permit the code

[[nodiscard]] getX() { return INT_MAX; }
float x = (float)getX();

which I don't believe is the intention. I've clarified the wording. Prompted by discussion in #1580

@shaneasd shaneasd mentioned this pull request Mar 16, 2020
Closed
@beinhaerter
Copy link
Contributor

getX <-> getMyInt? You probably meant to write the same function name in both lines!?

@hsutter
Copy link
Contributor

hsutter commented Mar 26, 2020

Editors call: Looks good, thanks for the catch!

@hsutter hsutter merged commit 040b141 into isocpp:master Mar 26, 2020
@hsutter hsutter self-assigned this Mar 26, 2020
hsutter added a commit that referenced this pull request Mar 26, 2020
@hsutter
Tweak to close #1588
b4bb11a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hsutter hsutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaneasd @beinhaerter @hsutter