-
Notifications
You must be signed in to change notification settings - Fork 573
Add proto for analysis messages #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d4f7ae
to
95fec11
Compare
/test build_api |
There's a few things missing here. #1. This new proto isn't being built. It needs to be built and linted. So it needs to be integrated into the make system. #2. If you want this content to be documented on istio.io, then you need to add the needed voodoo in the makefile in order to produce a .pb.html file. If you do not intend to document this on istio.io, then you should remove the $ directives in the comments at the top of the file, since those are only relevant for the doc publishing process. #3. Since I believe this proto will be used to describe status in Istio CRDs, then this probably will need to be integrated with the build of the .json files that described our schema to the API server. And will probably need to be integrated with the client-go libraries in order to enable programmatic access to the status state. @jasonwzm can help with the JSON stuff, @richardwxn can help with the client-go stuff. |
38c0626
to
4280229
Compare
/retest |
1 similar comment
/retest |
@zerobfd Can you rebase again to make gencheck work? |
4280229
to
eb380a7
Compare
analysis/v1alpha1/message.proto
Outdated
// Any message-type specific arguments that need to get codified. Optional. | ||
google.protobuf.Struct args = 2; | ||
|
||
// A list of strings specifying the path for resources which were the cause of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you clarify the meaning of 'path for resources' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended this to mean the "kind/namespace/resource" construction which identifies a resource, but then someone told me that wasn't a path, it was a qualified resource name. Although when I google around I don't see anything about that--is there a concept of a resource ID somewhere that I can link to?
eb380a7
to
8fa3005
Compare
8fa3005
to
e979386
Compare
See https://docs.google.com/document/d/1lCnDBVzRzkr22BWjzPtGk6EK6EvGOnVIe2qBpaiQ3SM/ for more context and discussion around the change.
I split the struct up a bit differently than the doc to make things (hopefully) more clear and make the developer UX a bit easier.