Issue 16404 - Documentation version selector dropdown #16478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
craigbox
reviewed
May 12, 2025
sbegin0
changed the title
|
Looking at the screenshot shared in slack, why is v1.27 listed above v1.26? Do we switch to preliminary.istio.io when we select v1.27? |
I was debating adding preliminary versions to the dropdown but decided against it, new deploy preview should show the updated menu that starts with latest (1.26) |
craigbox
reviewed
May 20, 2025
| @@ -71,3 +141,53 @@ | |||
| </form> | |||
| </nav> | |||
| </header> | |||
|
|
|||
| <script> | |||
There was a problem hiding this comment.
this should eventually end up in its own TS file.
|
This should definitely show preliminary when running on preliminary, but it would be OK to not show it when running on latest or older. (It should also highlight the current version if it's an archive site you're looking at) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tests a version selector dropdown under "Documentation" and includes previous logic for implementing a netlify edge function.
Reviewers